920882 - [Gaia] Support shrinking UI for NFC sharing function

Status: RESOLVED FIXED

(Firefox OS Graveyard :: NFC, defect)

Description

[Francis Lee [:frlee]]

When users try to share URL/vCards/image/video via NFC tag function, shrinking UI is needed to indicate the sharing process has been started.

Comment 1

[Juwei Huang[:juwei]]

Attachment: [NFC] Shrinking UI_20131001.pdf

Hi Frances,
Here's the spec for shrinking UI, please refer to attachment.

Comment 2

[Juwei Huang[:juwei]]

I also attached an animation for you to reference,
Here's the link:https://www.dropbox.com/s/fu3788ay9i344eo/NFC_%2020131001.mov

Thanks,
Juwei

Comment 3

[Kai-Chih Hu [:khu]]

This looks like something that system platform team needs to help. 
Ivan, could you help to make sure this is in the backlog for system platform team? 

Thank you.

Comment 4

[Kai-Chih Hu [:khu]]

Discussion on the UX draft:
1. If orientation happens in the shrinking UI, we agreed NOT to change the orientation. 
2. Both from sender's device and receiver's device, they will have the shrinking UI. 
3. Receiver will have slide in animation and sender will have swipe out animation. 
4. In the shrinking UI for both receiver and sender, there will have an indicator that indicate users to do the swipe action. 

Suggestions: 
1. Gaia team suggested to touch to share, not swipe to share.

Comment 5

[Kai-Chih Hu [:khu]]

5. Will have vibration during shrinking UI on both receiver and sender sides. 
6. Once we turn on Bluetooth(no matter it's BT pairing or BT transfer), Bluetooth won't be turned off.

Comment 6

[Ivan Tsay (:ITsay)]

Kevin, per our discussion, this engineering work will be tracked under NFC team to reduce the communication effort. Regarding the engineering resource tracking, Tim will regularly have the sync-up with system platform team members on their workload. I will also check if there is any impact on the tasks of system platform and your team regularly.

Comment 7

[(inactive after 6/18) Alive Kuo [:alive]]

See also https://bugzilla.mozilla.org/show_bug.cgi?id=860910

We're blocked by this bug and we block the following functional team work(per app).

Comment 8

[Garner Lee]

Meeting notes:

Concerning the P2P SENDER device display:

Upon hardware detection of another device, Gecko will fire a system message to system app/nfc_manager so that it can update the UI to indicate another NFC device is nearby.

Depending on User action on that UI, the system app fires a response to the gecko parent, which then relays "onpeerfound" or "onpeerlost" to the application. That event message from gecko to app is fired if, and only if, the application is in the foreground, and has the callbacks defined.

With the callback the application can take action (ie, initiate NFCPeer.sendNDEF(record) to the other device).

Comment 9

[Greg Weng [:snowmantw][:gweng][:λ]]

Notes from an offline discussion with UX:

* The tilted window should make animation to shrink deeper then bounce back to the normal position.
* If any other activities emerge, like file transferring requests from other already paired Bluetooth devices, or the screen changed due to timeout or user pressed the power button, the whole NFC flow should be seemed as interrupted, and should be terminated immediately. 
* Apps should receive a notification that it should prepare to make a NFC/Bluetooth transferring, to let itself paused if it's necessary. This is especially needed when a user is playing a sone/video/slideshow near the end, because the next second user send it out, the content would change to the main page of the app, and make the sharing stuff become ambiguous.

Comment 10

[(inactive after 6/18) Alive Kuo [:alive]]

(In reply to Greg Weng [:snowmantw] from comment #9)
> * Apps should receive a notification that it should prepare to make a
> NFC/Bluetooth transferring, to let itself paused if it's necessary. This is
> especially needed when a user is playing a sone/video/slideshow near the
> end, because the next second user send it out, the content would change to
> the main page of the app, and make the sharing stuff become ambiguous.

Android seems simply bring the app to background(pause/resume).
In this case we could do AppWindow.setVisible(false, true) to put a screenshot overlay.

Comment 11

[Greg Weng [:snowmantw][:gweng][:λ]]

So our platform can pause an app like that? Because the apps are still need to know the sharing request emerged. For example, if the vide app is playing a video, and the user suddently pair the NFC and start to drag it to send it out, the app at least should know the current video is the sharing target, not the next one changes during the sliding.

Of course it's not a proposal to create a new, special request to notify the app just for UX changing. I think that if the app already needs to know any NFC request in the sharing flow, it can do the pausing thing at the time.

Comment 12

[(inactive after 6/18) Alive Kuo [:alive]]

This is irrelevant to NFC but visibility state control.
// In system
  AppWindow.setVisible means mozbrowserAPI:setVisible
// In app
  window.addEventListener('visibilitychange', function () {
    if (document.hidden) {
      // do pause
    } else {
      // do resume
    }
  });

Comment 13

[Kai-Chih Hu [:khu]]

Hi, do we have a clear view on the target milestone on this bug now? Thanks.

Comment 14

[Ken Chang[:kenkai]]

It seems better to finish this bug before sprint5. If you think it isn't reasonable, please update target milestone.

Comment 16

[Greg Weng [:snowmantw][:gweng][:λ]]

Attachment: WIP patch

Need to discuss the events from NFC P2P enable to the UI component, and how to check NFC sending is successful or failed. So I only set feed back, not review.

Comment 17

[Greg Weng [:snowmantw][:gweng][:λ]]

Test:

window.dispatchEvent(new CustomEvent('nfc-p2pinit')); // If another device is close
window.dispatchEvent(new CustomEvent('nfc-p2pfin'));  // If the device is away

Comment 18

[Greg Weng [:snowmantw][:gweng][:λ]]

According to today's meeting, I would propose some notifications to notify the ShrinkingUI should be tilted or not, and the user has touched on it and sent it out. So the patch would be modified.

Comment 19

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8334479 [details] [review]
WIP patch

What is going to be reviewed?

Comment 20

[Greg Weng [:snowmantw][:gweng][:λ]]

Attachment: WIP patch

Add some notifications to control the shrinking UI, and to send notification to notify that user has sent it out.

I don't know whether this should be reviewed or not, because we may have some discussions with people are implementing NFC manager. So I set feedback flag first.

Comment 21

[Greg Weng [:snowmantw][:gweng][:λ]]

Comment on attachment 8336020 [details] [review]
WIP patch

Find some detailed bug; need to do some adjust.

Comment 22

[Greg Weng [:snowmantw][:gweng][:λ]]

About communication with ShrinkingUI:

ShrinkingUI will listen these events:

  'shrinking-start'        // Start shrinking
  'shrinking-stop'         // Stop shrinking
  'shrinking-receiving'    // Do receiving effects as UX spec

ShrinkingUI will send out this event:

  'shrinking-sent'         // User has tapped on app and dragged it out.

Comment 23

[Greg Weng [:snowmantw][:gweng][:λ]]

Attachment: Patch

Follow the new event way to trigger shrinking effects.

BTW: The Travis dead on irrelevant test: event I remove all my code, it still failed.

Comment 24

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8337508 [details] [review]
Patch

Some more comments.

Comment 25

[Greg Weng [:snowmantw][:gweng][:λ]]

Comment on attachment 8337508 [details] [review]
Patch

Fixed.

Travis is green: https://travis-ci.org/mozilla-b2g/gaia/builds/14502887

Comment 26

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8337508 [details] [review]
Patch

r+ with nits.

I'd like you have an unit test or integration test for this, please file a followup to do.

Comment 27

[Fang Shih [:fang]]

Attachment: NFC_bg.png

Hi Greg,
Here is the background image for shrinking UI! 
Thanks!

Comment 28

[Juwei Huang[:juwei]]

Attachment: nfc_arrow.png

Arrow updated.
Color: 00aacc

Comment 29

[Greg Weng [:snowmantw][:gweng][:λ]]

Ok, thanks.

Comment 30

[Fang Shih [:fang]]

Attachment: [e-mail]

@1.5 assets updated.
Thanks!

Comment 31

[Greg Weng [:snowmantw][:gweng][:λ]]

Comment on attachment 8337508 [details] [review]
Patch

Because the screenshot method and some UX design added, Alive may take a look.

Comment 32

[Greg Weng [:snowmantw][:gweng][:λ]]

Travis was green: https://travis-ci.org/mozilla-b2g/gaia/builds/14636643

Comment 33

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8337508 [details] [review]
Patch

nits

Comment 34

[Greg Weng [:snowmantw][:gweng][:λ]]

master: https://github.com/mozilla-b2g/gaia/commit/0c9b4c78e7259ef3e2da85e10354f06c488accff

Comment 35

[Juwei Huang[:juwei]]

Attachment: [NFC] Shrinking UI_20140207.pdf

Update spec due to bug 963010
Tap on Home button should be no function while NFC pairing.